| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Meson doesn't define HAVE_LOCALE_T for mscv |
| Date: | 2022-11-15 14:35:31 |
| Message-ID: | CAC+AXB3ZYOhdebqhYKPGT_boca0f5hPdW=2qnMHxRNtc7EaA7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 15, 2022 at 1:49 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hm. Is it right that the changes are only done for msvc? win32_port.h
> defines
> the types for mingw as well afaict.
>
> Yes, it does, but configure does nothing with them, so adding those
defines is a new feature for MinGW but a correction for MSVC.
PFA a patch for MinGW.
I've seen that when building with meson on MinGW the output for version()
is 'PostgreSQL 16devel on x86_64, compiled by gcc-12.2.0', which is not
wrong but I cannot tell that it was done on MinGW. Should we include the
'host_system' in PG_VERSION_STR?
Regards,
Juan José Santamaría Flecha
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-meson-define-HAVE_LOCALE_T-for-MinGW.patch | application/octet-stream | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2022-11-15 14:42:34 | Re: Avoid overhead open-close indexes (catalog updates) |
| Previous Message | Simon Riggs | 2022-11-15 14:27:55 | Re: when the startup process doesn't (logging startup delays) |