Re: BUG #16080: pg_ctl is failed if a fake cmd.exe exist in the current directory.

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: cilizili(at)protonmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16080: pg_ctl is failed if a fake cmd.exe exist in the current directory.
Date: 2019-10-26 14:15:04
Message-ID: CAC+AXB3Rj1KkQtLMGqpO5q9_+50Rzre_u4KZjXerX+kHfWsJ2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sat, Oct 26, 2019 at 3:36 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

>
> I do not think this is a bug. There are probably thousands of ways to
> break Postgres by misconfiguring your system, and this is one of 'em.
>
>
There is a difference in the behaviour for the WIN32 port. In other
platforms execl() is called from "src/bin/pg_ctl/pc_ctl" with the full path
("/bin/sh"), but for WIN32 the function CreateProcessAsUser() calls the CMD
command without a path, and this function has a search logic of its own [1].

If even this difference out is of any value I can propose a patch.

[1]
https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessasusera

Regards,

Juan José Santamaría Flecha

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2019-10-26 15:20:04 Re: BUG #16080: pg_ctl is failed if a fake cmd.exe exist in the current directory.
Previous Message Tom Lane 2019-10-26 13:36:41 Re: BUG #16080: pg_ctl is failed if a fake cmd.exe exist in the current directory.