| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix vcregress plpython3 warning |
| Date: | 2022-01-07 13:56:24 |
| Message-ID: | CAC+AXB1mW4QDy0E+HqYkxp3YitiJp_Lc8zKDxDCJ0kTrgUS9ug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 7, 2022 at 2:30 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> Yeah, this code is not a model of clarity though. I had to think through
> it and I write quite a bit of perl. I would probably write it something
> like this:
>
>
> s/EXTENSION (.*?)plpython2?u/EXTENSION $1plpython3u/g ;
>
> Yeah, I had to do some testing to figure it out. Based on what
regress-python3-mangle.mk does, I think it tries to ignore cases such as:
DROP EXTENSION IF EXISTS plpython2u CASCADE;
Which that expression would match. Maybe use a couple of lines as in the
make file?
s/EXTENSION plpython2?u/EXTENSION plpython3u/g
s/EXTENSION ([^ ]*)_plpython2?u/EXTENSION \$1_plpython3u/g
Regards,
Juan José Santamaría Flecha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Juan José Santamaría Flecha | 2022-01-07 13:58:01 | Re: Fix vcregress plpython3 warning |
| Previous Message | David Steele | 2022-01-07 13:51:14 | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |