Re: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: robionekenobi(at)bluewin(dot)ch, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment
Date: 2021-01-16 21:15:56
Message-ID: CAC+AXB1hEoM+=c6OnNfeDNZzvKtQBuo4qo7W9AkUBNVYEjAqYg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Jan 15, 2021 at 9:21 AM PG Bug reporting form <
noreply(at)postgresql(dot)org> wrote:

>
> in src\tools\msvc\Solution.pm the following test is not sufficient
> $self->{platform} =
> ($output =~ /^\/favor:<.+AMD64/m) ? 'x64' : 'Win32';
> because the cl /? returns:
> Microsoft (R) C/C++ Optimizing Compiler Version
> 19.28.29336 for x64
> Copyright (C) Microsoft Corporation. All rights reserved.
>

I see no bug here, that expression is looking for the line:
"/favor:<blend|AMD64|INTEL64|ATOM> select processor to optimize for, one
of:", which is one of the first printed options.
To make sure this is working in your environment, you should see "Detected
hardware platform: x64" when building.

Regards,

Juan José Santamaría Flecha

>
>

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Kisung Kim 2021-01-16 22:34:17 Re: BUG #16824: Planner chooses poor path on query with Merge Join and pagination
Previous Message Ricardo Ungureanu 2021-01-16 17:30:52 Re: BUG #16827: macOS interrupted syscall leads to a crash