Re: TAP tests and symlinks on Windows

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP tests and symlinks on Windows
Date: 2020-07-09 04:25:10
Message-ID: CAC+AXB1HU0VKB-rUzOQLj-R25dapCbF8=658q_RqZ_u52gyXWg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 8, 2020 at 7:18 PM Andrew Dunstan <
andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:

>
> On 7/8/20 12:22 PM, Alvaro Herrera wrote:
> > On 2020-Jul-08, Andrew Dunstan wrote:
> >
> >> On 7/8/20 11:07 AM, Juan José Santamaría Flecha wrote:
> >>> There is a utility cygpath [1] meant for the conversion between Unix
> >>> and Windows path formats, that might be a meaningful name also.
> >>>
> >>> [1] http://cygwin.net/cygwin-ug-net/cygpath.html
> >> Oh, good find. But unfortunately it's not present in my msys1
> installations.
> >>
> >> So we'll still need to use the 'pwd -W` trick for those.
> > I think his point is not to use that utility, just to use its name as
> > the name of the perl routine.
>
> That would be wholly misleading, since it's not needed at all when we're
> running running under cygwin.
>

MSYS does not include cygpath(), but MSYS2 does. I see why the name could
be confusing outside cygwin, but that is a given and it would point to a
utility that it mimics. Maybe a note for future reference could be enough.

msys_to_windows_path() seems too long, but is hard to misunderstand.

Regards,

Juan José Santamaría Flecha

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-07-09 04:47:27 Re: [doc] modifying unit from characters to bytes
Previous Message Kyotaro Horiguchi 2020-07-09 04:12:49 Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo