Re: [PATCH] Windows port add support to BCryptGenRandom

From: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Windows port add support to BCryptGenRandom
Date: 2019-12-18 08:52:07
Message-ID: CAC+AXB0diYaWV0nB95HmVkU7GtYjhLFv-WK=-WZv_5PO9W=MCw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 18, 2019 at 3:20 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Tue, Dec 17, 2019 at 02:20:20PM +0000, Ranier Vilela wrote:
> > As concern [1], at src/include/port/win32.h, the comments still
> > references Windows XP and claims about possible MingW break.
>
> This looks like a leftover of d9dd406, which has made the code to
> require C99. As we don't support compilation with Windows XP and
> require Windows 7, we should be able to remove all the dance around
> MIN_WINNT in win32.h, don't you think?
>
>
+1, there is a reference in [1] about that is possible to build PostgreSQL
using the GNU compiler tools for older versions of Windows, that should be
also updated.

[1] https://www.postgresql.org/docs/current/install-windows.html

Regards,

Juan José Santamaría Flecha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-12-18 08:56:42 allow_system_table_mods and DROP RULE
Previous Message Kyotaro Horiguchi 2019-12-18 08:36:58 Re: archive status ".ready" files may be created too early