Re: pg_stat_statements: calls under-estimation propagation

From: Sameer Thakur <samthakur74(at)gmail(dot)com>
To: Daniel Farina <daniel(at)heroku(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stat_statements: calls under-estimation propagation
Date: 2013-10-03 08:11:29
Message-ID: CABzZFEuaHsCq2JG313G__V6H+knn9h+WKeBMuLWkz-Py=dKcuw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 2, 2013 at 6:40 PM, Sameer Thakur <samthakur74(at)gmail(dot)com> wrote:
>>
>> Looks pretty good. Do you want to package up the patch with your
>> change and do the honors and re-submit it? Thanks for helping out so
>> much!
> Sure, will do. Need to add a bit of documentation explaining
> statistics session as well.
> I did some more basic testing around pg_stat_statements.max, now that
> we have clarity from Peter about its value being legitimate below 100.
> Seems to work fine, with pg_stat_statements =4 the max unique queries
> in the view are 4. On the 5th query the view holds just the latest
> unique query discarding the previous 4. Fujii had reported a
> segmentation fault in this scenario.
> Thank you for the patch

Please find the patch attached

regards
Sameer

Attachment Content-Type Size
pg_stat_statements-identification-v7.patch.gz application/x-gzip 7.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Asif Naeem 2013-10-03 08:30:10 Re: [PATCH] Add use of asprintf()
Previous Message Heikki Linnakangas 2013-10-03 07:48:48 Re: SSI freezing bug