Re: Removing savepointLevel from TransactionState

On Thu, Sep 29, 2011 at 1:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> writes:
> > I noticed that the savepointLevel member of TransactionStateData struct
> is
> > initialized to 0 from TopTransactionStateData, and never incremented or
> > decremented afterwards.
>
> > Since this is a file-local struct I think we can simply get rid of all
> > usages of this without any risk.
>
> ISTM you have detected a bug, not just dead code that should be removed.
> Surely those tests that throw error on savepointLevel change were
> meant to do something important?
>

That's surprising for dead-code removal!

Not sure which failures you're pointing to. `make check` before and after
the patch on master says 'All 126 tests passed.'

Let me know about the failures, and I'll see if I can find the root cause.

Regards,
--
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company