| From: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove extraneous break condition in logical slot advance function |
| Date: | 2023-10-21 16:56:15 |
| Message-ID: | CABwTF4X0c97t0PP+A7iTY5JfM76TYa0FUqrGZo1F5ZJomv-48g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 20, 2023 at 7:30 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> There exists an extraneous break condition in
> pg_logical_replication_slot_advance(). When the end of WAL or moveto
> LSN is reached, the main while condition helps to exit the loop, so no
> separate break condition is needed. Attached patch removes it.
>
> Thoughts?
+1 for the patch.
The only advantage I see of the code as it stands right now is that it
avoids one last call to CHECK_FOR_INTERRUPTS() by break'ing early. I
don't think we'd lose much in terms of performance by making one (very
cheap, in common case) extra call of this macro.
Best regards,
Gurjeet
http://Gurje.et
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-10-21 18:10:09 | Re: Remove extraneous break condition in logical slot advance function |
| Previous Message | Konstantin Knizhnik | 2023-10-21 12:16:33 | Custom explain options |