Re: memory barriers (was: Yes, WaitLatch is vulnerable to weak-memory-ordering bugs)

From: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: memory barriers (was: Yes, WaitLatch is vulnerable to weak-memory-ordering bugs)
Date: 2011-09-21 20:19:49
Message-ID: CABwTF4W3CqnGwnt8=eBsbY_6k7mtqxg=HT10SPEmSsXA4JbLpQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 14, 2011 at 4:29 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Mon, Aug 8, 2011 at 7:47 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > I've been thinking about this too and actually went so far as to do
> > some research and put together something that I hope covers most of
> > the interesting cases. The attached patch is pretty much entirely
> > untested, but reflects my present belief about how things ought to
> > work.
>
> And, here's an updated version, with some of the more obviously broken
> things fixed.
>

You declare dummy_spinlock variable as extren and use it, but it is not
defined anywhere. Wouldn't that be a linker error?

--
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-09-21 20:21:59 Re: memory barriers (was: Yes, WaitLatch is vulnerable to weak-memory-ordering bugs)
Previous Message Tom Lane 2011-09-21 20:05:06 Re: HeapTupleSatisfiesToast not setting XMIN_COMMITTED?