Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds

From: Gurjeet Singh <gurjeet(at)singh(dot)im>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Don't set LoadedSSL unless secure_initialize succeeds
Date: 2022-05-26 05:53:15
Message-ID: CABwTF4UCV4+5VdpMQVDq_mFr1=Fu=YdZoFmWyY9KWPC0AOdWTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 25, 2022 at 10:05 PM Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
> I have added a comment to be_tls_init(), which I hope explains this
> difference in treatment of errors. I have also added comments to
> be_tls_init(), explaining why we don't destroy/free the global
> SSL_context variable in case of an error in re-initialization of SSL;
> it's not just an optimization, it's essential to normal server
> operation.

Please see attached patch that reverts the unintentional removal of a
comment in be_tls_init(). Forgot to put that comment back in after my
edits.

Best regards,
Gurjeet
http://Gurje.et

Attachment Content-Type Size
revert-unintentional-deletion.patch application/octet-stream 653 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-05-26 07:23:14 Re: suboverflowed subtransactions concurrency performance optimize
Previous Message Amit Langote 2022-05-26 05:49:55 Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT