From: | Taylor Brown <taytay(at)taytay(dot)com> |
---|---|
To: | pgadmin-support(at)lists(dot)postgresql(dot)org |
Subject: | Bug: pldebugger compilation error "error: expected expression before ‘uint64’" after commit on 13 July, 2017 |
Date: | 2017-07-13 16:09:38 |
Message-ID: | CABjjfoEbYtJOjJ5FEqmbaCvMqzM0Y9Jv7ACDuc7M4rohGK3waQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-support |
pldebugger's readme said that I should file bugs here. If I'm in the wrong
place, just let me know where to direct this report.
This commit was checked in earlier today, and appears to have broken
compilation for our environment:
7b263b911851bb129fe6f139e183f4745e574e27
Diff:
diff --git a/pldbgapi.c b/pldbgapi.c
index fd135a3..c536c09 100644 (file)
--- a/pldbgapi.c
+++ b/pldbgapi.c
@@ -797,7 +797,7 @@ Datum pldbg_get_stack( PG_FUNCTION_ARGS )
*/
snprintf(
callCount, PLDBG_STRING_MAX_LEN, UINT64_FORMAT,
- UINT64CONST(srf->call_cntr)
+ uint64(srf->call_cntr)
);
values[0] = callCount;
Here's the error after cloning the repo and running make:
jenkins-node-29% USE_PGXS=1 make
gcc -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute
-Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard
-g -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Werror=format-security -I/usr/include/mit-krb5 -fPIC -pie
-fno-omit-frame-pointer -fpic -I. -I./ -I/usr/include/postgresql/9.6/server
-I/usr/include/postgresql/internal -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE
-I/usr/include/libxml2 -I/usr/include/tcl8.6 -c -o pldbgapi.o pldbgapi.c
pldbgapi.c: In function ‘pldbg_get_stack’:
pldbgapi.c:800:4: error: expected expression before ‘uint64’
uint64(srf->call_cntr)
^
make: *** [pldbgapi.o] Error 1
Here's our gcc version:
gcc --version
gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
My C is rusty, so I am afraid I don't have a great suggestion other than
reverting the change :) Please let me know if I can do anything to help.
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2017-07-13 16:22:18 | Re: Bug: pldebugger compilation error "error: expected expression before ‘uint64’" after commit on 13 July, 2017 |
Previous Message | Dave Page | 2017-07-13 15:17:58 | pgAdmin 4 v1.6 Released! |