| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Date: | 2025-02-17 06:20:41 |
| Message-ID: | CABdArM7v0N0Kz1x0HjnuJZgDC8e=ZGgfCgSywsm4imgmpWghDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 17, 2025 at 11:29 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Feb 14, 2025 at 5:30 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > Here is a summary of changes in v78:
> >
>
> A few minor comments:
> 1.
> Slots that appear idle due to a disrupted connection between
> + the publisher and subscriber are also excluded, as they are managed by
> + <link linkend="guc-wal-sender-timeout"><varname>wal_sender_timeout</varname></link>.
> ...
>
> How do we exclude the above kind of slots? I think it is trying to
> cover the case where walsender is not exited even after the connection
> is broken between publisher and subscriber. The point is quite
> confusing and adds much less value. So, we can remove it.
>
> 2.
> - * Returns true when any slot have got invalidated.
> + * Returns true if there are any invalidated slots.
> ...
>
> I find the existing comment more suitable for this function and easy to follow.
>
> Apart from the above, I have changed a few other comments and minor
> cosmetic cleanup.
>
Here are the v79 patches with the above changes and comments from [1]
incorporated.
--
Thanks,
Nisha
| Attachment | Content-Type | Size |
|---|---|---|
| v79-0001-Introduce-inactive_timeout-based-replication-slo.patch | application/octet-stream | 33.5 KB |
| v79-0002-Add-TAP-test-for-slot-invalidation-based-on-inac.patch | application/octet-stream | 6.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul Jungwirth | 2025-02-17 06:42:15 | Re: SQL:2011 application time |
| Previous Message | Michael Paquier | 2025-02-17 06:18:04 | Re: Move wal_buffers_full to WalUsage (and report it in pgss/explain) |