Re: Introduce XID age and inactive timeout based replication slot invalidation

From: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
Date: 2024-12-16 10:40:28
Message-ID: CABdArM6qPsZE9v7qymNTwiRt68DgOJ+LsAMhweTxZx1xr1cVOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 16, 2024 at 9:58 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Nisha.
>
> Thanks for the v55* patches.
>
> I have no comments for patch v55-0001.
>
> I have only 1 comment for patch v55-0002 regarding some remaining
> nitpicks (below) about the consistency of phrases.
>
> ======
>
> SUGGESTIONS:
>
> Docs (idle_replication_slot_timeout): Invalidate replication slots
> that have remained idle longer than this duration.
> Docs (idle_timeout): means that the slot has remained idle longer than
> the configured idle_replication_slot_timeout duration.
>
> Code (guc var comment): Invalidate replication slots that have
> remained idle longer than this duration.
> Code (guc_tables): Sets the duration a replication slot can remain
> idle before it is invalidated.
>
> Msg (errdetail): This slot has been invalidated because it has
> remained idle longer than the configured \"%s\" duration.
> Msg (errdetail): The slot has remained idle since %s, which is longer
> than the configured \"%s\" duration.
>

Here is the v56 patch set with the above comments incorporated.

--
Thanks
Nisha

Attachment Content-Type Size
v56-0001-Enhance-replication-slot-error-handling-slot-inv.patch application/octet-stream 10.6 KB
v56-0002-Introduce-inactive_timeout-based-replication-slo.patch application/octet-stream 28.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2024-12-16 10:56:38 Re: DOCS: pg_createsubscriber wrong link?
Previous Message Ashutosh Bapat 2024-12-16 10:14:04 Re: SQL Property Graph Queries (SQL/PGQ)