Re: Introduce XID age and inactive timeout based replication slot invalidation

From: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
Date: 2024-11-19 07:12:55
Message-ID: CABdArM5141FHGvfNYD=pCybLDpmEWbRXFJW3HnEoieMScZ62-g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Attached is the v49 patch set:
- Fixed the bug reported in [1].
- Addressed comments in [2] and [3].

I've split the patch into two, implementing the suggested idea in
comment #5 of [2] separately in 001:

Patch-001: Adds additional error reports (for all invalidation types)
in ReplicationSlotAcquire() for invalid slots when error_if_invalid =
true.
Patch-002: The original patch with comments addressed.

~~~~

[1] https://www.postgresql.org/message-id/CALDaNm2mwkVFLfe8pLcU1W5Oy1vRr1Wzp53XGV08kr4Z2%3DSJpA%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAHut%2BPt6s-qNPdxH5%3D-fr2QKLEv0h16sQ8EvLiGJ-SdQNS6pbw%40mail.gmail.com
[3] https://www.postgresql.org/message-id/CALDaNm2VQW_gpOJ-QWkEA_h18DN31ELEz2_7QmwWCAg9%3DZew4A%40mail.gmail.com

--
Thanks,
Nisha

Attachment Content-Type Size
v49-0001-Add-error-handling-while-acquiring-a-replication.patch application/octet-stream 7.9 KB
v49-0002-Introduce-inactive_timeout-based-replication-slo.patch application/octet-stream 29.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shlok Kyal 2024-11-19 07:14:37 Re: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY
Previous Message vignesh C 2024-11-19 07:12:44 Re: Skip collecting decoded changes of already-aborted transactions