| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Date: | 2024-12-04 09:30:52 |
| Message-ID: | CABdArM4N60XShbmxXgz4z8ENQGPOMhXSKzvmskdv8V=mQsYOOA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 3, 2024 at 1:09 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Nisha,
>
> Thanks for updating the patch!
>
> > Fixed. It is reasonable to align with other timeout parameters by
> > using milliseconds as the unit.
>
> It looks you just replaced to GUC_UNIT_MS, but the documentation and
> postgresql.conf.sample has not been changed yet. They should follow codes.
> Anyway, here are other comments, mostly cosmetic.
>
Here is v53 patch-set addressing all the comments in [1] and [2].
[1] https://www.postgresql.org/message-id/CAHut%2BPsQM79f34LLBGq4UeRuZ1URWP6JNZtdN2khYPrLc1YqrQ%40mail.gmail.com
[2] https://www.postgresql.org/message-id/TYAPR01MB5692B7687EE7981AA91BA5B9F5362%40TYAPR01MB5692.jpnprd01.prod.outlook.com
--
Thanks,
Nisha
| Attachment | Content-Type | Size |
|---|---|---|
| v53-0001-Enhance-replication-slot-error-handling-slot-inv.patch | application/x-patch | 10.6 KB |
| v53-0002-Introduce-inactive_timeout-based-replication-slo.patch | application/x-patch | 28.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | maumau307 | 2024-12-04 09:57:44 | RE: Does RelCache/SysCache shrink except when relations are deleted? |
| Previous Message | Pierre Giraud | 2024-12-04 08:53:14 | doc: Remove LC_COLLATE and LC_CTYPE from SHOW command |