Re: Improve the connection failure error messages

From: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improve the connection failure error messages
Date: 2024-05-31 12:45:22
Message-ID: CABdArM41SRs_sX-G2xyc4RZVR5NDz4A9=Fh+2Hpj6iCYb=yhng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 26, 2024 at 1:10 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 22 Mar 2024, at 11:42, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> > Here is the v4 patch with changes required in slotfuncs.c and slotsync.c files.
>
> - errmsg("could not connect to the primary server: %s", err));
> + errmsg("\"%s\" could not connect to the primary server: %s", app_name.data, err));
>
> Messages like this should perhaps have translator comments to indicate what the
> leading "%s" will contain?

Attached v5 patch with the translator comments as suggested.

--
Thanks,
Nisha

Attachment Content-Type Size
v5-0001-Improve-the-connection-failure-error-messages.patch application/octet-stream 7.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2024-05-31 13:02:49 Re: Schema variables - new implementation for Postgres 15
Previous Message Yao Wang 2024-05-31 12:09:53 Re: 回复: An implementation of multi-key sort