Re: Remove usage of finalizers ?

As for me, introducing server-side leak would be plain wrong. If it will be
done, please announce in the list, I will stop recommending using
postgresql in java projects.
23 жовт. 2013 03:12, користувач "Tom Dunstan" <pgsql(at)tomd(dot)cc> написав:

> On 21 October 2013 23:03, Dave Cramer <pg(at)fastcrypt(dot)com> wrote:
> > Please send patches for possible solutions. I think I would be OK with
> > removing them and letting people find their Statement leaks
>
> One option if we want to keep the existing behaviour available in some
> way would be to remove the finalize method from AbstractJdbc2Statement
> and create subclasses of the various concrete statement classes which
> could be used when a debug flag is switched on. e.g.
> DebugJdbc3Statement, DebugJdbc3PreparedStatement,
> DebugJdbc3CallableStatement etc which have the finalizer present.
>
> There would be quite a few of them though, and we'd need to have a
> switch everywhere that one of those is instantiated, or introduce a
> factory. It's a bit gross.
>
> IMO tracing non-closed statement leaks is probably better done in a
> connection pool or jdbc debugging library anyway, so maybe we
> shouldn't bother and just remove it.
>
> One question is this, though: how many users out there aren't closing
> their statements currently and are relying, accidentally or
> deliberately, on the current behaviour?
>
> Tom
>