Re: When does the archives app show PNGs inline?

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: PostgreSQL WWW <pgsql-www(at)postgresql(dot)org>
Subject: Re: When does the archives app show PNGs inline?
Date: 2021-03-16 10:48:39
Message-ID: CABUevEzzCEW18QPDe+1XcHgxx04-1yHCBkG10Ejn9deQemT2xA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Tue, Mar 16, 2021 at 4:44 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> Hi,
>
> Just curious... why does this message have inline images...
>
> https://www.postgresql.org/message-id/VI1PR0701MB69608CBCE44D80857E59572EF6CA0%40VI1PR0701MB6960.eurprd07.prod.outlook.com
>
> ... while this one doesn't?
>
> https://www.postgresql.org/message-id/CA+hUKG+MDpwF2Eo2LAvzd=pOh81wUTsrwU1uAwR-v6OGBB6+7g@mail.gmail.com

There's some very old and very trivial logic for that:

https://github.com/postgres/pgarchives/blob/master/django/archives/mailarchives/models.py#L111

Basically, it has to be png, gif or jpeg and it has to be < 75kB.

It would probably be better to do that based on the actual dimensions
of the image, but that was at some point a quickfix.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Bruce Momjian 2021-03-16 23:53:32 Commitfest URL
Previous Message Thomas Munro 2021-03-16 03:43:28 When does the archives app show PNGs inline?