Re: %ENV warnings during builds

On Mon, Jul 4, 2011 at 23:30, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 07/03/2011 05:14 PM, Brar Piening wrote:
>>
>> schrieb Magnus Hagander:
>>>
>>> I think you've stumbled on just about all the bits of the MSVC build
>>> system we haven't perlized. Maybe we should complete that task, and turn
>>> clean.bat, pgbison.bat and pgflex.bat into pure one-line wrappers. (It
>>> was
>>> done for builddoc just a few weeks ago).
>>> Yeah, give nthat you can't get anything useful done without perl
>>> anyway, I don't see any argument for keeping them at this point.
>>>
>> I've already stumbled into this while preparing the VS2010 support and
>> came to the same conclusion.
>> In my VS2010 support patch I've already created perl replacements for
>> those two and removed the batch files completely.
>> Certainly those two could also stay around as mere wrappers but in my
>> opinion they only mess up the directory without adding any relevant benefit.
>
>
> Hmm, I missed that you had done this. Here are two replacement perl scripts
> I knocked up, but haven't yet tested. One of the things about them is that
> they remove knowledge of particular .l and .y files. and instead get the
> required invocation options from the relevant Makefiles. I think that's a
> lot better than the horrid hackery we have in the batch files.

Definitely agreed. Those were ugly hacks that were supposed to be
temporary, but yeah, we all know what happens to temporary things :O

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/