Re: [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm

On Thu, Sep 9, 2021 at 2:53 PM Célestin Matte <celestin(dot)matte(at)cmatte(dot)me> wrote:
>
> > Hi!
>
> Hi,
>
> > Thanks! the fix looks good in general -- but how did you actually hit
> > the bug? I've been trying to reproduce it to verify the test, but I
> > can't figure out how... In all my tests, d['apiurl'] ends up being ''
> > (and actually existing), which makes it not a problem.
>
> Filling the form in /admin/account/communityauthsite/add/ with the "push changes" option activated and an incorrect value for apiurl (something that is not actually a URL) gives me an error (see Traceback below).
> With the patch, I correctly get an error message on the page instead ("API url must be specified to enable push changes!").
> I also thought it didn't work with a correct value, but I can't seem to reproduce that now.

Ah, you're right. I only tested with it being empty, not with it being
an invalid value. That makes perfect sense.

Good spot! Patch applied, thanks!

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/