| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Christian Ullrich <chris(at)chrullrich(dot)net> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| Date: | 2016-04-25 13:24:44 |
| Message-ID: | CABUevEzicpYAUOF9ZHkee1-c-gvokKAmr708sqta4H71bOZOWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich <chris(at)chrullrich(dot)net>
wrote:
> * Magnus Hagander wrote:
>
> Add putenv support for msvcrt from Visual Studio 2013
>>
>> This was missed when VS 2013 support was added.
>>
>> Michael Paquier
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab
>>
>
> Just noticed something. This DLL detection by name has never worked in
> debug builds where the DLL names end in "d". Is that important?
That's an interesting point. I guess our release builds are never with
debugging info - but could it make the buildfarm "wrong"?
Fixing it should probably be as easy as trying each dll with the specified
name and also with a "d" as a suffix?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christian Ullrich | 2016-04-25 13:27:50 | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| Previous Message | Tom Lane | 2016-04-25 02:56:32 | Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christian Ullrich | 2016-04-25 13:27:50 | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| Previous Message | Thom Brown | 2016-04-25 13:12:39 | Re: [BUGS] Breakage with VACUUM ANALYSE + partitions |