| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Dave Page <dpage(at)pgadmin(dot)org> |
| Subject: | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
| Date: | 2018-11-08 17:26:16 |
| Message-ID: | CABUevEzhcennJPdOB43VKD421LWDFo4Gzs=E3f8FgbcCR3u=Sg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 8, 2018 at 3:53 PM Sergei Kornilov <sk(at)zsrv(dot)org> wrote:
> Hi
>
> >> Sure, but what are we going to achieve with that number? What
> >> information user is going to get by that? If it can help us to ensure
> >> that it has reset the expected number of statements, then I can see
> >> the clear usage, but without that, the return value doesn't seem to
> >> have any clear purpose. So, I don't see much value in breaking
> >> compatibility.
> >>
> >> Does anyone else have an opinion on this matter?
> >
> > This was proposed by Sergei Kornilov in
> > https://postgr.es/m/3368121530260059@web21g.yandex.ru saying that "it
> > would be nice" to return it. Maybe he has an use case in mind? I don't
> > see one myself.
> No, i have no specific usecase for this. Silently remove all matching rows
> and return void is ok for me. But i still think LOG ereport is not useful.
>
I would much prefer it to be a return code rather than a forced LOG
message. Log message spam is very much a thing, and things that are logged
as LOG will always be there.
It could also be made to take a parameter saying log yes/no with a default
value, but that seems like possible overengineering of a fairly simple
functionality.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2018-11-08 17:30:45 | security release |
| Previous Message | Alvaro Herrera | 2018-11-08 16:38:09 | Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation |