Re: "pgstat wait timeout" just got a lot more common on Windows

On Fri, May 11, 2012 at 3:35 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Thu, May 10, 2012 at 6:52 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Oh ... while hacking win32 PGSemaphoreLock I saw that it has a *seriously*
>>> nasty bug: it does not reset ImmediateInterruptOK before returning.
>>> How is it that Windows machines aren't falling over constantly?
>
>> Hmm. the commit you made to fix it says it changes how
>> ImmediateInterruptOK is handled, but there was not a single line of
>> code that actually changed that? Or am I misreading this completely?
>
> Exit is now out the bottom of the loop, not by a raw "return;".

oh, d'uh. Sorry, missed that one completely.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/