Re: Deal with <>s in message IDs

On Oct 30, 2014 1:13 PM, "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com> wrote:
>
> Magnus Hagander wrote:
> > On Thu, Oct 30, 2014 at 12:56 PM, Vik Fearing <vik(at)xocolatl(dot)community>
wrote:
> > > On 10/30/2014 12:46 PM, Magnus Hagander wrote:
> > >> On Wed, Oct 29, 2014 at 5:28 PM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
wrote:
> > >>> If you're referring to the <> issue, my problem is this: If you
paste
> > >>> '<message-ID>' into commitfest instead of just 'message-ID' you get
no
> > >>> results, because it creates a URL that contains the <>s. Obviously
> > >>> commitfest could be taught to strip <>, but ISTM it's more useful
to have
> > >>> pgarchives do it.
> > >>
> > >> Yeah, I still don't understand what you mean. And I'd still need an
> > >> example link that shows the wrong thing, both to understand it and to
> > >> verify a fix..
> > >
> > >
> > >
http://www.postgresql.org/message-id/%3CCABUevEyy05BHq21BA0CgYcsmvd06ZKXpXPAwr1khZ+RGk+4PUA@mail.gmail.com%3E
> > >
> > > versus
> > >
> > >
http://www.postgresql.org/message-id/CABUevEyy05BHq21BA0CgYcsmvd06ZKXpXPAwr1khZ+RGk+4PUA@mail.gmail.com
> >
> > Ok, I'm sorry, but I'm still confused here. Where do we actually
> > generate the first link, the one that's wrong? Do we put the wrong
> > thing in our thread browsing somewhere? If so, I'm still failing to
> > find it :)
>
> Some people enter message-ids with the < > delimiters in the commitfest
app.
>
> I'm not really sure this really belongs in the archives app. We could
> just have the commitfest app remove them on input.
>

Oh, now I get it. Yeah, based on that it does sound like the wrong place to
fix it. Though if it's easy enough it might be worth doing for convenience.
I'll see if there's some place to stick a regexp that can do it safely.

/Magnus