| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Sergei Kornilov <sk(at)zsrv(dot)org> |
| Subject: | Re: Make pg_checksums complain if compiled BLCKSZ and data folder's block size differ |
| Date: | 2019-03-17 11:03:04 |
| Message-ID: | CABUevEzZWBz3yjtzCOaiHJSsQsn=e2W0LT8T9j11=XFzy=p_gg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 17, 2019 at 6:47 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sat, Mar 16, 2019 at 09:18:34AM +0100, Fabien COELHO wrote:
> > I think it would be better to adapt the checksum computation, but this is
> > indeed non trivial because of the way the BLCKSZ constant is hardwired
> into
> > type declarations.
>
> That's actually the possibility I was pointing out upthread. I am not
> sure that the use cases are worth the effort though.
>
It may be worthwhile, but I think we shouldn't target that for v12 --
consider it a potential improvement for upcoming version. Let's focus on
the things we have now to make sure we get those polished and applied first.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-03-17 11:40:52 | Re: using index or check in ALTER TABLE SET NOT NULL |
| Previous Message | Magnus Hagander | 2019-03-17 11:01:31 | Re: Make pg_checksums complain if compiled BLCKSZ and data folder's block size differ |