From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Reporting hba lines |
Date: | 2012-06-29 11:28:40 |
Message-ID: | CABUevEzPw06fF6Y2KK=nx0uAEYnjmsS356WaRsMYDFYZxpYcZg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 27, 2012 at 4:27 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Wed, Jun 27, 2012 at 4:14 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> cases where people are modifying the wrong hba file. Can we show
>>> the source text of the hba line?
>
>> We don't currently keep the full source text around - but we certainly
>> could do that if we wanted to.
>
> If we're concerned about providing a message like this, I think it'd be
> well worthwhile. We presumably would only store the active lines not
> comment lines, so the extra memory space would be negligible in just
> about any real use-case.
Turned out to be a bit more work than I thought, since the current
parser reads pg_hba byte by byte, and not line by line. So I had to
change that. See attached, seems reasonable?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Attachment | Content-Type | Size |
---|---|---|
hba_line2.patch | application/octet-stream | 12.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Boszormenyi Zoltan | 2012-06-29 12:43:49 | Re: [PATCH 10/16] Introduce the concept that wal has a 'origin' node |
Previous Message | Magnus Hagander | 2012-06-29 10:22:18 | Re: [ADMIN] pg_basebackup blocking all queries with horrible performance |