Re: BUG #6082: server segfault - pg_stat_reset_shared(null)

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Steve Haslam <araqnid(at)googlemail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6082: server segfault - pg_stat_reset_shared(null)
Date: 2011-07-03 11:19:04
Message-ID: CABUevEzPEXyqdfyWCDh6Lm6AOjFPBzrutB22_pAszHgEsorisg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Jun 29, 2011 at 23:52, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Wed, Jun 29, 2011 at 15:31, Steve Haslam <araqnid(at)googlemail(dot)com> wrote:
>>> => select pg_stat_reset_shared(null)
>>> *server segfault*
>
>> Thanks for the report - fixed, and will be in next releases.
>
> Seems like the more appropriate fix in HEAD is to mark the function
> strict in pg_proc.h.

I considered that, but gave it up when I realized it would require a
new initdb and I wanted the same fix everywhere. But agreed that it's
cleaner, so I've reverted my previous patch on HEAD and made this
change instead. Left the old patch on backbranches (including 9.1) so
we don't force an initdb there...

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2011-07-03 16:31:15 Re: BUG #6080: information_schema.columns.column_default contains NULL inconsistently
Previous Message Tom Lane 2011-07-03 05:40:51 Re: view + explain + index scan -> bogus varno: 65001 (with some variations)