| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Typos in logical decoding |
| Date: | 2016-07-18 16:50:15 |
| Message-ID: | CABUevEzLcPuTkR57XPyNZ0d-YKrK2YKnjC+Wv_esXue2FJ_fXQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 18, 2016 at 11:00 AM, Antonin Houska <ah(at)cybertec(dot)at> wrote:
> While reading the logical decoding code I noticed a few supposedly mistyped
> comments, see the diff below.
>
Applied, thanks.
> Besides that, output_plugin_options argument of CreateInitDecodingContext
> function is unused, and the function passes NIL to the corresponding
> argument
> of StartupDecodingContext. This looks to me like a thinko.
>
I agree it looks like a thinko, and AFAICT all internal uses pass NIL there
anyway so it makes no difference on those. I'll wait for someone more
familiar with that code to comment though :)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-07-18 16:58:45 | Re: Regression tests vs existing users in an installation |
| Previous Message | Peter Eisentraut | 2016-07-18 16:47:56 | Re: Regression tests vs existing users in an installation |