Re: [PATCH] Relocation of tablespaces in pg_basebackup

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Gabriele Bartolini <gabriele(dot)bartolini(at)2ndquadrant(dot)it>
Cc: Steeve Lennmark <steevel(at)handeldsbanken(dot)se>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Relocation of tablespaces in pg_basebackup
Date: 2014-01-10 11:27:23
Message-ID: CABUevEzKvfPDtySRHx1W3Su7WEhjbz3sqGGFKM9e0M-V0RbQLQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 10, 2014 at 12:25 PM, Gabriele Bartolini <
gabriele(dot)bartolini(at)2ndquadrant(dot)it> wrote:

> Hi Steeve,
>
> Il 09/01/14 22:38, Steeve Lennmark ha scritto:
> > I'm a barman user myself so that was actually my initial thought.
>
> Ah! Very good!
> > If there aren't some kind of hidden internal that I've missed I don't see
> > a way to convert an OID (only have OID and path at this stage) to a
> > tablespace name. This solution, even though not optimal, is a lot
> > better than my initial one where I used the OID directly.
>
> Try:
>
> SELECT spcname, oid, pg_tablespace_location(oid) FROM pg_tablespace
>
>
That would require a second connection to the database. You cannot run that
query from the walsender session. And that's exactly the issue that Steeve
pointed out in his first email.

I think it's better to let pg_basebackup work at the lower level, and then
leave it to higher level tools to be able to do the mapping to names.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-01-10 11:29:42 Re: [PATCH] Relocation of tablespaces in pg_basebackup
Previous Message Gabriele Bartolini 2014-01-10 11:25:52 Re: [PATCH] Relocation of tablespaces in pg_basebackup