Re: invalid combination of options "-D - -F t -X stream" in pg_basebackup

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: invalid combination of options "-D - -F t -X stream" in pg_basebackup
Date: 2016-12-19 16:43:14
Message-ID: CABUevEzHoSCoyB1OX0tb=tGwya+qeyRK2zma+e1WDSLgcWdBRA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 19, 2016 at 5:39 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> Hi,
>
> Isn't it better to forbid the conbination of the options "-D -", "-F t" and
> "-X stream" in pg_basebackup? This is obviously invalid setting and the
> docs
> warns this as follows. But currently users can specify such setting and
> pg_basebackup can exit unexpectedly with an error.
>
> -----------------------
> If the value - (dash) is specified as target directory, the tar contents
> will
> be written to standard output, suitable for piping to for example gzip.
> This is only possible if the cluster has no additional tablespaces.
> -----------------------
>

Yes, definitely. I'd say that's an oversight in implementing the support
for stream-to-tar that it did not detect this issue.

Do you want to provide a patch for it, or should I?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-12-19 16:44:51 Re: Quorum commit for multiple synchronous replication.
Previous Message Fujii Masao 2016-12-19 16:39:59 invalid combination of options "-D - -F t -X stream" in pg_basebackup