Re: Remove "unsupported version" warning for Greenplum

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: "Andreas 'ads' Scherbaum" <adsmail(at)wars-nicht(dot)de>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Remove "unsupported version" warning for Greenplum
Date: 2016-01-22 09:57:24
Message-ID: CABUevEzC1Hc80dxhbCV9-j9vmM5xchH6xidsYeK_4aa7SVHrCA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Jan 22, 2016 at 10:43 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Thu, Jan 21, 2016 at 10:54 PM, Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
> >
> >
> > On Thu, Jan 21, 2016 at 11:35 PM, Andreas 'ads' Scherbaum
> > <adsmail(at)wars-nicht(dot)de> wrote:
> >>
> >> On 21.01.2016 10:31, Dave Page wrote:
> >>>
> >>> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum
> >>> <adsmail(at)wars-nicht(dot)de> wrote:
> >>>>
> >>>> On 19.01.2016 16:03, Dave Page wrote:
> >>>>>
> >>>>>
> >>>>>
> >>>>> Your patch won't apply again. I have no idea why - I'm trying to do
> it
> >>>>> on my Mac, which is a *nix under the hood (they don't use Mac line
> >>>>> endings any more - that was the old Mac OS 9 and earlier from a
> decade
> >>>>> or so ago iirc). How are you creating them? The normal way is to do
> >>>>> something like:
> >>>>
> >>>>
> >>>>
> >>>> And how does the attached work? Fresh clone again, only difference is
> a
> >>>> warning (not an error) for whitespaces removed.
> >>>
> >>>
> >>> Still doesn't apply. I tried on the following systems:
> >>>
> >>> Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
> >>> Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
> >>> CentOS release 6.7 (Final) - git version 1.7.1
> >>>
> >>> I'm fairly convinced at this stage that there's something funky on
> >>> your system. Perhaps we should take a look next week when we're both
> >>> in Brussels?
> >>>
> >>
> >> After debugging back and forth with Magnus, it looks like that Google
> Mail
> >> is fooling you. Your downloaded file has a different line ending, and
> your
> >> file is 3269 bytes, where the original file is 3210 bytes. That's 59
> >> additional line breaks.
> >>
> >> 4fa0990a1020e425fe95b99ea9f186de gp-warning2.diff
> >>
> >> The file you download from the archive:
> >>
> >> http://www.postgresql.org/message-id/569EBEA2.5040903@wars-nicht.de
> >>
> >> is also correct.
>
> Well that's weird. But why is it only happening with your patches? I
> apply patches from others constantly without issues.
>

What MIME types do you get those in typically? Could be that gmail is
reacting to it being text/x-patch and not application/x-patch or something?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-01-22 10:04:16 Re: Remove "unsupported version" warning for Greenplum
Previous Message Dave Page 2016-01-22 09:43:37 Re: Remove "unsupported version" warning for Greenplum