Re: pg_stat_statements temporary file

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Geoghegan <peter(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stat_statements temporary file
Date: 2012-05-25 14:51:21
Message-ID: CABUevEzB65UL4psu+AT1dRg-Tiy9+qxj_5AqxDNQnUBj3O0mPg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 25, 2012 at 4:09 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Geoghegan <peter(at)2ndquadrant(dot)com> writes:
>> On 25 May 2012 14:13, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>> I still think we should consider the placement of this file to not be
>>> in the global/ directory, but this is a quick (back-patchable) fix...
>
>> Where do you suggest the file be written to?
>
> Given that pgstats keeps its permanent file in global/, I think the
> argument that pg_stat_statements should not do likewise is pretty thin.

Fair enough. As long as the file is unlinked after reading (per my
patch), it doesn't cause issues on a standby anymore, so it's a lot
less important, I guess. It's mostly "namespace invasion" at this
time...

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-05-25 15:01:45 Re: pg_stat_statements temporary file
Previous Message Tom Lane 2012-05-25 14:41:23 Re: pg_dump and thousands of schemas