Re: New developer papercut - Makefile references INSTALL

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, samay sharma <smilingsamay(at)gmail(dot)com>, Tim McNamara <tim(at)mcnamara(dot)nz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: New developer papercut - Makefile references INSTALL
Date: 2022-03-07 21:05:33
Message-ID: CABUevEz7bQBFqHv5eDSZaSBmvyrfx+Un3GxVbxEfduESjQoZvA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 7, 2022 at 4:57 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > If anything, I'm more behind the idea of just getting rid of the
> > INSTALL file. A reference to the install instructions in the README
> > should be enough today. The likelihood of somebody getting a postgres
> > source tarball and trying to build it for the first time while not
> > having internet access is extremely low I'd say.
>
> I agree that there's no longer a lot of reason to insist that the
> installation instructions need to be present in a flat text file
> as opposed to some other way.
>
> However, just putting a URL into README seems problematic, because how
> will we ensure that it's the correct version-specific URL? (And it does
> need to be version-specific; the set of configure options changes over
> time, and that's not even mentioning whatever user-visible effects
> changing to meson will have.) You could imagine generating the URL
> during tarball build, but that does nothing for the people who pull
> directly from git.
>
> I thought briefly about directing people to read
> doc/src/sgml/html/installation.html, but that has the same problem
> that it won't be present in a fresh git pull.

Yeah, if we just care about tarballs that works, but then it also
works to inject the version number in the README file.

But taking a step back, who is the actual audience for this? Do we
*need* a link pointing directly there, or is it enough to just point
to "use the docs on the web"? We can't link to the incorrect version,
but can we just link to /docs/ and leave it at that?

If not, could we make the change of URL a part of the branching step?
Branch to a stable release would the include modifying README, and be
mad ea step of version_stamp.pl?

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2022-03-07 21:11:19 Re: logical decoding and replication of sequences
Previous Message Imseih (AWS), Sami 2022-03-07 20:34:12 Re: [BUG] Panic due to incorrect missingContrecPtr after promotion