Re: [PATCH pglister] Add Archived-At header to delivered messages

On Wed, Mar 3, 2021 at 11:15 AM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> On Tue, Mar 2, 2021 at 11:41 AM Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com> wrote:
> >
> > Hi,
> >
> > Magnus Hagander a écrit :
> > > There are a few issues.
> > >
> > > * It needs a rebase because the migration doesn't work (needs to be
> > > based on the latest)
> > > * You cannot CREATE OR REPLACE a view if you add a field in the
> > > middle. The new field has to be added at the end.
> > > * It crashes on lists that don't have an archive. I think you just
> > > need an "if self.archive_mailurlpattern:" wrapping it
> >
> > Thanks for the review. Please find attached a new version of the patch
> > fixing these issues hopefully.
> >
> > Let me know if there's anything else,
>
> Looks great, thanks! Applied and deployed!
>
> (So this email should have the header)

And it did. Almost right, needed to strip <> from beginning/end of
messageid. It *works* without that, but it's an uglier URL and
generates redirect. I've pushed a fix.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/