Re: moving basebackup code to its own directory

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: moving basebackup code to its own directory
Date: 2022-08-09 16:12:16
Message-ID: CABUevEz=Q+fA2yG5wyuPtfPKOJP=_O1=MM1E1_HFA4vC5im0tg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 9, 2022 at 6:08 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> Hi,
>
> I was thinking that it might make sense, to reduce clutter, to move
> *backup*.c from src/backend/replication to a new directory, perhaps
> src/backend/replication/backup or src/backend/backup.
>
> There's no particular reason we *have* to do this, but there are 21 C
> files in that directory and 11 of them are basebackup-related, so
> maybe it's time, especially because I think we might end up adding
> more basebackup-related stuff.
>
> Thoughts?
>
>
Those 11 files are mostly your fault, of course ;)

Anyway, I have no objection. If there'd been that many files, or plans to
have it, in the beginning we probably would've put them in
replication/basebackup or something like that from the beginning. I'm not
sure how much it's worth doing wrt effects on backpatching etc, but if
we're planning to add even more files in the future, the pain will just
become bigger once we eventually do it...

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhihong Yu 2022-08-09 16:13:02 Re: Fast COPY FROM based on batch insert
Previous Message Robert Haas 2022-08-09 16:08:04 moving basebackup code to its own directory