Re: Commit emails to -committers

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: Commit emails to -committers
Date: 2021-08-20 13:35:10
Message-ID: CABUevEywXCREoJTO-JS6W44KAZbVmW5mAH37pULwrT+cAdANoQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Fri, Aug 20, 2021 at 3:30 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> > On 19.08.21 21:59, Stephen Frost wrote:
> >>> One thing I don't like is the proposed From:. Setting things that way
> >>> sometimes causes people's MUAs to record the given address to the
> >>> person's name -- and I'm sure both parties would be upset if they sent
> >>> email to Stephen Frost and it ended up delivered to
> >>> noreply(at)postgresql(dot)org(dot)
>
> > I have gotten email from
> > Stephen Frost <notifications(at)github(dot)com>
> > so it seems it's accepted in other parts to do it this way.
>
> I wouldn't be surprised if Stephen is objecting precisely because of
> unpleasant experience with that github "feature".

FWIW, Alvaro is the one who was doing the complaining...

> (My wife constantly complains about how Apple Mail will try to
> auto-complete To: with random addresses it finds somewhere in her
> mail folder, so I can believe there's a real issue there.)

Yeah, and gmail (being probably by far the most common client used)
also auto-learns those things.

For that reason I'd lean towards having something just be "PostgreSQL
commits <noreply(at)postgresql(dot)org>" and not put the name in there at all
-- the name would of course go in the body.

Another option we could go with would be to have the email sender be
"Stephen Frost <sfrost(at)postgresql(dot)org>", since we have by policy been
giving all committers such an email address. We'd need to add the
ability to do that mapping into the commit message script as it
doesn't have it right now, but it would be doable. And of course, it
would suddenly make it more important for committers to ensure that
this forwarder or mailbox actually works.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Tom Lane 2021-08-20 13:56:44 Re: Commit emails to -committers
Previous Message Tom Lane 2021-08-20 13:30:12 Re: Commit emails to -committers