Re: Blanks in the first line before the first word in the code boxes

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Daniel Westermann <daniel(dot)westermann(at)dbi-services(dot)com>, pgsql-docs <pgsql-docs(at)postgresql(dot)org>
Subject: Re: Blanks in the first line before the first word in the code boxes
Date: 2018-04-03 13:12:12
Message-ID: CABUevEykw8e1kgd1AYAL5n0gBOXkaBXn1rRHhPc7bHTVgPwO0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Mon, Apr 2, 2018 at 5:59 PM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> On 4/1/18 11:55, Magnus Hagander wrote:
> > However, why does devel work fine when the others are broken. It's the
> > exact same code that's run to load the docs. The *input* to the loader
> > must also be different at some point.
>
> In devel, the raw HTML output looks like
>
> ... <pre class="synopsis">
> ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...
>
> (with a line break)
>
> but before it looks like
>
> ... <pre class="synopsis">ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...
>
> (without a line break).
>
> So maybe some part of the processing code thinks it should do some kind
> of "indentation" here.
>
>
I think I found the problem, and pushed a fix for it. Basically it turns
off indentation completely on pre-11 versions., I elected to keep indention
on dev because it works there, and it makes debugging any of the formatting
a lot easier.

I've pushed the fix and reloaded the 10 docs. I have not reloaded earlier
branches yet, but I'd be interested in some people reviewing a bunch of
pages in the 10 docs mainly to see if (1) it fixes all the cases, and (2)
it actually breaks some *other* cases.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Bruce Momjian 2018-04-03 13:24:39 Re: Synopsis of SELECT statement: UNION, INTERSECTION, EXCEPT
Previous Message PG Doc comments form 2018-04-03 05:29:35 Correction for 9.6 documentation for OpenBSD