Re: pgsql: Implement backup API functions for non-exclusive backups

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Implement backup API functions for non-exclusive backups
Date: 2016-04-05 18:40:05
Message-ID: CABUevEyf9gdNg5_XOF9hGzESkTMSVaNe+YrtOCXtMWSF5arTnA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Apr 5, 2016 at 8:35 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Tue, Apr 5, 2016 at 2:11 PM, Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
> > Implement backup API functions for non-exclusive backups
> >
> > Previously non-exclusive backups had to be done using the replication
> protocol
> > and pg_basebackup. With this commit it's now possible to make them using
> > pg_start_backup/pg_stop_backup as well, as long as the backup program can
> > maintain a persistent connection to the database.
> >
> > Doing this, backup_label and tablespace_map are returned as results from
> > pg_stop_backup() instead of being written to the data directory. This
> makes
> > the server safe from a crash during an ongoing backup, which can be a
> problem
> > with exclusive backups.
> >
> > The old syntax of the functions remain and work exactly as before, but
> since the
> > new syntax is safer this should eventually be deprecated and removed.
> >
> > Only reference documentation is included. The main section on backup
> still needs
> > to be rewritten to cover this, but since that is already scheduled for a
> separate
> > large rewrite, it's not included in this patch.
> >
> > Reviewed by David Steele and Amit Kapila
>
> We've typically tried to keep the width of commit messages narrow
> enough that 'git log' looks OK in an 80-character window; this one is
> wide enough that it doesn't.
>

Huh. It would appear I've somehow screwed up the commit-message-mode that
is supposed to warn me about that.

My apologies.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-05 18:51:28 pgsql: Fix PL/Python for recursion and interleaved set-returning functi
Previous Message Robert Haas 2016-04-05 18:35:57 Re: pgsql: Implement backup API functions for non-exclusive backups