Re: New developer papercut - Makefile references INSTALL

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, samay sharma <smilingsamay(at)gmail(dot)com>, Tim McNamara <tim(at)mcnamara(dot)nz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: New developer papercut - Makefile references INSTALL
Date: 2022-02-09 21:32:59
Message-ID: CABUevEyZ_dPP_PM=vpnfOSxyfqrD_TsZtjfkqWvCy2K73622_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 21, 2022 at 11:53 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2022-01-21 17:25:08 -0500, Tom Lane wrote:
> > Perhaps this could be finessed by making updating of INSTALL
> > the responsibility of some post-commit hook on the git server.
> > Not sure that we want to go there, though. In any case, that
> > approach would negate your point about seeing the results.
>
> It would. I guess it'd still be better than the situation today, but...

post-commit hooks don't run on the git server, they run locally on
your machine. There is a "post receive" hook that runs on the git
server, but we definitely don't want that one to fabricate new commits
I think.

And it certainly cannot *modify* the commit that came in in flight, as
that would change the hash, and basically break the whole integrity of
the commit chain.

We could certainly have a cronjob somewhere that ran to check that
they were in sync and would auto-generate a patch if they weren't, for
a committer to review, but I'm not sure how much that would help?

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2022-02-09 21:39:11 Re: [PATCH v2] use has_privs_for_role for predefined roles
Previous Message Robert Haas 2022-02-09 20:58:29 Re: [PATCH v2] use has_privs_for_role for predefined roles