Re: pg_basebackup and pg_stat_tmp directory

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup and pg_stat_tmp directory
Date: 2014-01-28 08:51:14
Message-ID: CABUevEyZ5L9Z=g-pzX3+dTBUKdROfRSDBGNaZu+hw6=_t2mCHg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 28, 2014 at 6:11 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>wrote:

> On Tue, Jan 28, 2014 at 9:26 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
> wrote:
> > Hi,
> >
> > The files in pg_stat_tmp directory don't need to be backed up because
> they are
> > basically reset at the archive recovery. So I think it's worth
> > changing pg_basebackup
> > so that it skips any files in pg_stat_tmp directory. Thought?
>
> I think this is good idea, but can't it also avoid
> PGSTAT_STAT_PERMANENT_TMPFILE along with temp files in
> pg_stat_tmp
>
>
All stats files should be excluded. IIRC the PGSTAT_STAT_PERMANENT_TMPFILE
refers to just the global one. You want to exclude based
on PGSTAT_STAT_PERMANENT_DIRECTORY (and of course based on the
guc stats_temp_directory if it's in PGDATA.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rajeev rastogi 2014-01-28 09:13:15 Observed Compilation warning in WIN32 build
Previous Message Peter Geoghegan 2014-01-28 08:45:00 Re: Storing pg_stat_statements query texts externally, pg_stat_statements in core