| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Marko Kreen <markokr(at)gmail(dot)com> |
| Cc: | "Dr(dot) Andreas Kunert" <kunert(at)cms(dot)hu-berlin(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Feature request: Logging SSL connections |
| Date: | 2014-01-17 12:33:37 |
| Message-ID: | CABUevEyYqigS9bjv2JTKLn=mhzgs4bL=j2vvxxzYZ_mJ2WBMaw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 8, 2013 at 10:27 AM, Marko Kreen <markokr(at)gmail(dot)com> wrote:
> On Fri, Dec 06, 2013 at 02:53:27PM +0100, Dr. Andreas Kunert wrote:
> > >>Anything else missing?
> > >
> > >Functionally it's fine now, but I see few style problems:
> > >
> > >- "if (port->ssl > 0)" is wrong, ->ssl is pointer. So use just
> > > "if (port->ssl)".
> > >- Deeper indentation would look nicer with braces.
> > >- There are some duplicated message, could you restructure it so that
> > > each message exists only once.
> >
> > New version is attached. I could add braces before and after the
> > ereport()-calls too, but then I need two more #ifdefs to catch the
> > closing braces.
>
> Thank you. Looks good now. I added it to next commitfest:
>
> https://commitfest.postgresql.org/action/patch_view?id=1324
>
>
Applied, thanks!
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Layton | 2014-01-17 12:34:46 | Re: [Lsf-pc] Linux kernel impact on PostgreSQL performance |
| Previous Message | Magnus Hagander | 2014-01-17 11:41:59 | Re: [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio |