Re: Link to beta docs

On Mon, Jul 18, 2016 at 4:23 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:

> On Mon, Jul 18, 2016 at 12:14:32PM +0200, Magnus Hagander wrote:
> >
> >
> > On Mon, Jul 18, 2016 at 2:42 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >
> > Our doc webpage, https://www.postgresql.org/docs/ says:
> >
> > 9.6 beta
> >
> > links to the right place with title:
> >
> > PostgreSQL 9.6beta2 Documentation
> >
> > but in should say "9.6 beta2". Would someone please update this?
> >
> >
> > This does not come from the doc webpage rendering specifically, it's in
> the
> > standard output from our SGML build. So it should probably be directed
> to the
> > -docs list, but I'm not sure there are more people reading there. (Run a
> local
> > build and look in index.html and you'll see the same). It gets it from
> the
> > VERSION variable in Makefile.
>
> Well, I ran 'make' in the /doc/src/sgml/ directory. The Makefile has:
>
> version.sgml: $(top_srcdir)/configure
> { \
> echo "<!ENTITY version \"$(VERSION)\">"; \
> echo "<!ENTITY majorversion \"$(MAJORVERSION)\">"; \
> } > $@
>
> and version.sgml has:
>
> <!ENTITY version "9.6beta2">
> <!ENTITY majorversion "9.6">
>
> That tells me that the Makefile VERSION is already "9.6beta2". I
> checked index.html too:
>
> $ grep -i beta index.html
> >PostgreSQL 9.6beta2 Documentation</TITLE
> >PostgreSQL 9.6beta2 Documentation</A
>
> and when I run 'make' I see:
>
> $ make
> { \
> echo "<!ENTITY version \"9.6beta2\">"; \
> echo "<!ENTITY majorversion \"9.6\">"; \
> } > version.sgml
>
> What am I missing? I don't see a "9.6beta" anywhere.
>
>
Oh, now I see what you're referring to. My bad.

And then the proper answer is no, it should not say 9.6beta2. Because it
lists the *major* version, not the minor. We do attach the beta to make
sure people realize it's not released, but if you look at the same place
for 9.5 for example, you see it says 9.5 not 9.5.3.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/