Re: [PATCH] pgweb: Add ARCHIVES_FRONT_ADDRESS to allow configuration of archives

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
Cc: pgsql-www(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] pgweb: Add ARCHIVES_FRONT_ADDRESS to allow configuration of archives
Date: 2022-01-15 17:38:52
Message-ID: CABUevEyFhSzPWT86DVP10Nst14sqKVT0i31fMB69T6n_dTR0-g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Wed, Oct 27, 2021 at 11:45 AM Célestin Matte
<celestin(dot)matte(at)cmatte(dot)me> wrote:
>
> > This patch adds a new parameter ARCHIVES_FRONT_ADDRESS, which is then never used. Instead it passes in ARCHIVES_SEARCH_SERVER into the templates.
> >
> > I'm pretty sure that's not intentional? They should both b ARCHIVES_FRONT_ADDRESS?
>
> Oops, indeed, this is the product of a failed git merge --squash.
>
> Fixed patch attached.

Finally cycling back to this one, sorry about the long delay. This
does look much better, applied with th modification that it should
take the whole URL and not just the hostname -- which maks it work
better in development for example.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2022-01-15 17:38:56 Re: [PATCH] pgweb: Add ARCHIVES_FRONT_ADDRESS to allow configuration of archives
Previous Message Christophe Pettus 2022-01-14 18:59:18 Re: Wiki editor request - username timm