| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Disallow SSL compression? |
| Date: | 2021-03-05 16:44:20 |
| Message-ID: | CABUevEyF1hORUb8h1j+Ksf2X8Ud7e3X+MpDb8zP4_qqn72amEw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 5, 2021 at 1:37 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Mar 05, 2021 at 01:21:01PM +0100, Daniel Gustafsson wrote:
> > On 5 Mar 2021, at 08:04, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >> FWIW, I would vote to nuke it from all those places, reducing a bit
> >> pg_stat_get_activity() while on it. Keeping it around in the system
> >> catalogs may cause confusion IMHO, by making people think that it is
> >> still possible to get into configurations where sslcompression could
> >> be really enabled. The rest of the patch looks fine to me.
> >
> > Attached is a version which removes that as well.
>
> Peter, Magnus, any comments about this point?
We've broken stats views before. While it'd be nice if we could group
multiple breakages at the same time, I don't think it's that
important. Better to get rid of it once and for all from as many
places as possible.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tsunakawa.takay@fujitsu.com | 2021-03-05 16:54:17 | RE: [POC] Fast COPY FROM command for the table with foreign partitions |
| Previous Message | Tom Lane | 2021-03-05 16:41:35 | Re: contrib/cube - binary input/output handlers |