Re: pgsql: Allow extensions to add new backup targets.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow extensions to add new backup targets.
Date: 2022-03-21 10:37:48
Message-ID: CABUevEyBm55E6aTs=OWVMa6p0=E_xpVeTXyF9ojvw48uTPMsPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Mar 15, 2022 at 7:33 PM Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>
> Allow extensions to add new backup targets.
>
> Commit 3500ccc39b0dadd1068a03938e4b8ff562587ccc allowed for base backup
> targets, meaning that we could do something with the backup other than
> send it to the client, but all of those targets had to be baked in to
> the core code. This commit makes it possible for extensions to define
> additional backup targets.
>
> Patch by me, reviewed by Abhijit Menon-Sen.
>
> Discussion: http://postgr.es/m/CA+TgmoaqvdT-u3nt+_kkZ7bgDAyqDB0i-+XOMmr5JN2Rd37hxw@mail.gmail.com
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/e4ba69f3f4a1b997aa493cc02e563a91c0f35b87
>
> Modified Files
> --------------
> src/backend/replication/Makefile | 1 +
> src/backend/replication/Makefile.orig | 49 ++++++
> src/backend/replication/basebackup.c | 82 ++++------
> src/backend/replication/basebackup_target.c | 238 ++++++++++++++++++++++++++++
> src/include/replication/basebackup_target.h | 66 ++++++++
> 5 files changed, 381 insertions(+), 55 deletions(-)

This one has a tiny copy/paste error where the idenfiication comment
for basebackup_target.c claims it's basebackup_gzip.c. I've pushed a
fix.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2022-03-21 10:37:54 pgsql: Fix typo in file identification
Previous Message Andres Freund 2022-03-21 02:13:19 pgsql: pgstat: introduce pgstat_relation_should_count().