Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs
Date: 2013-01-09 12:34:12
Message-ID: CABUevExorwSfhJPJFX-AWrsUXH4efO91tbGaudw-OMar0-T4qA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Am I the only one who finds this way of posting patches really annoying?

Here is a patch with no description other than a list of changed
files. And discussion happens in a completely different email.

What's wrong with just posting the patch as a regular attachment(s) to
a regular thread, like other people do?

Yes, I'm well aware that some mailers thread them in right. Our
archives code does. But many MUAs don't. But even when using a MUA
that threads it correctly, I find it quite annoying that you have to
open one email to read the comments and a different email toview the
patch.

It may be just me. But it may be others as well, so I figured I should
raise the issue :)

//Magnus

On Wed, Jan 9, 2013 at 12:27 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> ---
> contrib/oid2name/oid2name.c | 52 +------------
> contrib/pg_upgrade/pg_upgrade.h | 5 +-
> contrib/pg_upgrade/util.c | 49 -------------
> contrib/pgbench/pgbench.c | 54 +-------------
> src/backend/utils/mmgr/mcxt.c | 78 +++++++++++---------
> src/bin/initdb/initdb.c | 40 +---------
> src/bin/pg_basebackup/pg_basebackup.c | 2 +-
> src/bin/pg_basebackup/pg_receivexlog.c | 1 +
> src/bin/pg_basebackup/receivelog.c | 1 +
> src/bin/pg_basebackup/streamutil.c | 38 +---------
> src/bin/pg_basebackup/streamutil.h | 4 -
> src/bin/pg_ctl/pg_ctl.c | 39 +---------
> src/bin/pg_dump/Makefile | 6 +-
> src/bin/pg_dump/common.c | 1 -
> src/bin/pg_dump/compress_io.c | 1 -
> src/bin/pg_dump/dumpmem.c | 76 -------------------
> src/bin/pg_dump/dumpmem.h | 22 ------
> src/bin/pg_dump/dumputils.h | 1 +
> src/bin/pg_dump/pg_backup_archiver.c | 1 -
> src/bin/pg_dump/pg_backup_custom.c | 2 +-
> src/bin/pg_dump/pg_backup_db.c | 1 -
> src/bin/pg_dump/pg_backup_directory.c | 1 -
> src/bin/pg_dump/pg_backup_null.c | 1 -
> src/bin/pg_dump/pg_backup_tar.c | 1 -
> src/bin/pg_dump/pg_dump.c | 1 -
> src/bin/pg_dump/pg_dump_sort.c | 1 -
> src/bin/pg_dump/pg_dumpall.c | 1 -
> src/bin/pg_dump/pg_restore.c | 1 -
> src/bin/psql/common.c | 50 -------------
> src/bin/psql/common.h | 10 +--
> src/bin/scripts/common.c | 49 -------------
> src/bin/scripts/common.h | 5 +-
> src/include/port/palloc.h | 19 +++++
> src/include/utils/palloc.h | 12 +--
> src/port/Makefile | 8 +-
> src/port/dirmod.c | 75 +------------------
> src/port/palloc.c | 130 +++++++++++++++++++++++++++++++++
> 37 files changed, 218 insertions(+), 621 deletions(-)
> delete mode 100644 src/bin/pg_dump/dumpmem.c
> delete mode 100644 src/bin/pg_dump/dumpmem.h
> create mode 100644 src/include/port/palloc.h
> create mode 100644 src/port/palloc.c
>
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2013-01-09 12:42:54 Commitfest Topics
Previous Message Andres Freund 2013-01-09 12:19:19 Re: Extra XLOG in Checkpoint for StandbySnapshot