Re: [PATCH 1/2] pgarchives: Add missing authentication backend to settings.py

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
Cc: PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH 1/2] pgarchives: Add missing authentication backend to settings.py
Date: 2022-01-15 17:54:20
Message-ID: CABUevExckBnyw1cUvioswExNrR8cnyM_U12HnWMbvcGTWxYVdg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Thu, Oct 28, 2021 at 7:42 PM Célestin Matte <celestin(dot)matte(at)cmatte(dot)me> wrote:
>
> Hello,
>
> Authentication when using private archives in pgarchives is broken with current settings.py file.
> This first patch add a missing backend in settings.py, without which sessions aren't registered and users get redirected indefinitely.
> In the second patch of this series, I add missing parameters for configuring PGAUTH, copying the ones from pglister.

Yeah, technically it's configured to use django auth but then we
override that elsewhere. It might be worthwhile to remove those
hardcoded redirects and make it possible to use the system with the
built in django auth. But until someone does that, I agree that
putting a working value into AUTHENTICATION_BACKEND is definitely
better.

And also the example file that was in your patch #2.

Both patches squashed and applied. Thanks!

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2022-01-15 18:06:35 Re: [PATCHES] pglister: make organization name generic
Previous Message Magnus Hagander 2022-01-15 17:38:56 Re: [PATCH] pgweb: Add ARCHIVES_FRONT_ADDRESS to allow configuration of archives