From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
Cc: | PostgreSQL WWW <pgsql-www(at)postgresql(dot)org> |
Subject: | Re: Dropping training events |
Date: | 2018-12-06 14:57:03 |
Message-ID: | CABUevExccBpdX7xPDhtGcQzXkrF8GqQfCNNzbGkbYzxqxR4=sw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-www |
On Thu, Dec 6, 2018 at 3:25 PM Jonathan S. Katz <jkatz(at)postgresql(dot)org>
wrote:
> Hi,
>
> On 12/5/18 10:44 AM, Magnus Hagander wrote:
>
> > PFA a patch that implements this.
>
> Thanks for working on this! Overall it looks good, and testing the core
> functionality appears to work.
>
> A couple of comments:
>
> 1. In "templates/index.html" on line 128, there is still a reference to
> "training sessions" - given some events (e.g. conferences) have training
> sessions attached to them, I odn't think it's imperative we remove those
> words, but wanted to note it in order to solicit feedback.
>
I did notice that one as well, an considered it something we should leave.
2. In "templates/pages/download/recognition.html" There is a reference
> to this wiki page:
>
>
> https://wiki.postgresql.org/wiki/NewsEventsApproval#Approving_Events_and_Event-Related_News_.28excluding_training.29
>
> First, we probably have to update the wiki as we have removed the
> training section (either remove the content or move it to a "Deprecated"
> section?) which would possibly cause use to update the title for
> readability purposes. Updating the URL would not break the URL, but it
> would break the anchor jump.
>
We should definitely update the page, yes. I don't think we need to create
a deprecated session -- there is version history on the page after all.
TBH, I don't much care about anchor jumps inside the page breaking. As long
as the main URL doesn't change (which it won't, as you say), it's fine.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
From | Date | Subject | |
---|---|---|---|
Next Message | Jonathan S. Katz | 2018-12-06 15:24:58 | Re: Dropping training events |
Previous Message | Jonathan S. Katz | 2018-12-06 14:25:20 | Re: Dropping training events |