| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Joe Van Dyk <joe(at)tanga(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #7809: Running pg_dump on slave w/ streaming replication fails if there are unlogged tables |
| Date: | 2013-01-20 16:01:51 |
| Message-ID: | CABUevExUMXhPZei3cMcVMTdkSS2SR0QQmy42MpELkhB+X8d-Yw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Sun, Jan 20, 2013 at 4:59 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> + PGresult *res = ExecuteSqlQueryForSingleRow(fout, "SELECT pg_is_in_recovery()");
>
> That function call needs to be schema-qualified for security.
Ha! I wonder if I can set up an autoresponder to *myself* with that
review whenever I commit to pgdump :) Thanks!
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-01-20 16:45:31 | Re: Passing connection string to pg_basebackup |
| Previous Message | Tom Lane | 2013-01-20 15:59:43 | Re: [BUGS] BUG #7809: Running pg_dump on slave w/ streaming replication fails if there are unlogged tables |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-01-20 16:14:47 | Re: pg_upgrade and system() return value |
| Previous Message | Tom Lane | 2013-01-20 15:59:43 | Re: [BUGS] BUG #7809: Running pg_dump on slave w/ streaming replication fails if there are unlogged tables |